[system] Pass the stylesheet directly to GlobalStyles
#43739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siriwatknp
added
package: system
1 task
Netlify deploy previewhttps://deploy-preview-43739--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
DiegoAndai
reviewed
Sep 13, 2024
…gen-css-vars-order
Added a regression test (I think for use case like this, it's best to run the test in the real browser env). Also, tested with sandbox build, it fixes the issue. https://app.argos-ci.com/mui/material-ui/builds/32120/109050219 |
DiegoAndai
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To unblock #43708
Added regression test: https://app.argos-ci.com/mui/material-ui/builds/32120/109050219
Root cause
After the fix from #43632, if
<StyledEngineProvider injectFirst>is used, the global style injection order is included in the Emotion normal process likestyledAPI. Meaning that Emotion will process the end of the GlobalStyles first. For example,Screen.Recording.2567-09-13.at.11.49.57.mov
This causes unexpected behavior because the way CSS variables are generated should be ordered by:
Fix
This PR put the ordered stylesheet into a single
GlobalStylesso that the injection order does not matter.Screen.Recording.2567-09-13.at.11.51.36.mov